Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Actions workflows to upstream latest versions #212

Merged
merged 4 commits into from
Feb 8, 2024
Merged

Update GitHub Actions workflows to upstream latest versions #212

merged 4 commits into from
Feb 8, 2024

Conversation

nanxstats
Copy link
Collaborator

@nanxstats nanxstats commented Feb 5, 2024 •
edited
Loading

This PR updates all GitHub Actions workflows to their latest versions from upstream (r-lib/actions).

The upstream changes mostly involves updating actions/checkout and actions/upload-artifact to v4, which updated the default runtime to Node.js 20.

I just ran

usethis::use_github_action("check-standard")
usethis::use_github_action("pkgdown")
usethis::use_github_action("test-coverage")
usethis::use_github_action("style")

Also, this fixes #213.

@nanxstats nanxstats requested a review from elong0527 February 5, 2024 03:30
@nanxstats
Copy link
Collaborator Author

The segmentation fault you see in macOS is similar to tidyverse/dplyr#6961. Not related to the PR.

@nanxstats
Copy link
Collaborator Author

I created an issue on a possible cause after looking into the problematic test file: #213 Not entirely sure if it's relevant.

@nanxstats
Copy link
Collaborator Author

OK, here is what I found and did to improve the testing situation, now this is ready:

  • Removing the unnecessary svg() and dev.off() calls (dbb3c03) resolved the macOS segmentation fault. This is the culprit.

  • I further removed the library() calls from tests/testthat.R, individual tests, and qualified the involved namespaces in tests (7896111) following the standard.

  • Additionally, I used the testthat native mechanism skip_if_not_installed() to replace requireNamespace() in the tests driven by officer (f808ad1).

@nanxstats nanxstats merged commit c55513d into master Feb 8, 2024
8 checks passed
@nanxstats nanxstats deleted the gha branch February 8, 2024 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elong0527 elong0527 elong0527 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unnecessary SVG saving in tests?
2 participants
@nanxstats @elong0527